Ok to kill active emacsql-sqlite processes when quitting?

twelvety · May 25, 2020, 7:28pm

Occasionally when I’m using Org-Roam and I then quit Doom Emacs, I get a Process List buffer listing out an emacsql-sqlite process that’s still running, and an alert saying:

Active processes exist; kill them and exit anyway? (y or n)

Is it OK to say “yes” to this?
Will I harm the Org-Roam database if I do?
Should I be doing something to prevent this message?

Thanks!

cobblepot · May 27, 2020, 2:35am

I get this often too. Are you on Windows like me? I remember the org-roam docs having something specific about issues with emacsql-sqlite and Windows.

jethro · May 27, 2020, 11:25am

Yes, it’s okay to do this. What Emacs does is it sends a SIGTERM, which means ends the connection nicely.

I’m curious as to why you still see that. Here, we mark emacsql-sqlite connections to not prompt for this, and on Linux, I don’t see that prompt anymore, so maybe that doesn’t work for Windows.

github.com

org-roam/org-roam/blob/1551a1a4f15ed08c7ce16e9a24a8831fe7a5d175/org-roam-db.el#L87


(defun org-roam-db ()
  "Entrypoint to the Org-roam sqlite database.
Initializes and stores the database, and the database connection.
Performs a database upgrade when required."
  (unless (and (org-roam-db--get-connection)
               (emacsql-live-p (org-roam-db--get-connection)))
    (let* ((db-file (org-roam-db--get))
           (init-db (not (file-exists-p db-file))))
      (make-directory (file-name-directory db-file) t)
      (let ((conn (emacsql-sqlite3 db-file)))
        (set-process-query-on-exit-flag (emacsql-process conn) nil)
        (puthash (file-truename org-roam-directory)
                 conn
                 org-roam-db--connection)
        (when init-db
          (org-roam-db--init conn))
        (let* ((version (caar (emacsql conn "PRAGMA user_version")))
               (version (org-roam-db--update-maybe conn version)))
          (cond
           ((> version org-roam-db--version)
            (emacsql-close conn)

twelvety · May 27, 2020, 12:19pm

Thanks @jethro and @cobblepot ! I should have mentioned that I’m on macOS Mojave if that helps. It doesn’t happen every time, but I would say every 5th or 6th time I quit Doom Emacs. Good to know it’s nothing to worry about. I’ll let you know if it persists. Thanks!

Topic		Replies	Views
What's clearing out the nodes table? Troubleshooting	4	294	November 22, 2022
Database error message in Windows Troubleshooting	2	838	November 4, 2020
Installation requires nonexistent emacsql-sqlite3-1.0.0 Troubleshooting	9	1261	July 1, 2020
Help for installation of org roam in windows Troubleshooting	20	4952	August 27, 2020
Emacs 29 and org-roam-database-connector set to 'sqlite-builtin, but "emacs-sqlite-common" does not exist Troubleshooting	3	837	March 15, 2023

Ok to kill active emacsql-sqlite processes when quitting?

Related Topics